janhoy commented on code in PR #5346:
URL: https://github.com/apache/solr/pull/5346#discussion_r4575019921


##########
solr/core/src/java/org/apache/solr/cli/StopPortTool.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.cli;
+
+import org.apache.commons.cli.Option;
+import org.apache.commons.cli.Options;
+import picocli.CommandLine;
+
+/**
+ * Prints the Jetty stop port of the Solr node listening on a given port, read 
from the {@code
+ * -DSTOP.PORT} argument of the running process.
+ *
+ * <p>Helper for the {@code bin/solr} stop logic, which needs each node's own 
stop port rather than
+ * one value for the whole invocation. Hidden because it is of no use outside 
the scripts.
+ */
[email protected](
+    name = "stop-port",
+    description = "Prints the Jetty stop port of the Solr node running on the 
given port.",
+    hidden = true)
+public class StopPortTool extends ToolBase {

Review Comment:
   Not sure if a separate tool is the best way for this -- is there not some 
other tool that would have access to this data? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to