github-actions[bot] commented on PR #5324: URL: https://github.com/apache/solr/pull/5324#issuecomment-6885398336
**Automated PR readiness judgements** (LLM-generated; may be wrong; not updated on later pushes). ⚠️ Prefer PRs against `main`. This PR targets branch_9x. - ✅ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already present - ✅ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference): type: added <!-- The PR introduces three new opt-in builder methods (withConnectionMaxDuration, withMaxHttp2ConnectionsPerHost, withConnectionIdleTimeout) for Http2SolrClient, which are new features requiring user action to utilize. --> - ⚠️ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) **— missing**: The new builder options for Http2SolrClient are user-facing configuration parameters that should be documented in the Solr Reference Guide under the SolrJ client configuration section. - ✅ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages): not needed <!-- The changes are additive with defaults that preserve existing behavior (e.g., max HTTP/2 connections remains 4, idle timeout remains -1), so no user action is required upon upgrading. --> - ✅ Tests: included <!-- The PR modifies production logic in Http2SolrClient to handle new configuration parameters and connection pool settings, which warrants new tests to verify the behavior of the new options and their interaction with existing settings. --> <!-- Assessed commit 41d3ba1b24ac2c047683ebc8d7063db2951bb06d --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
