punAhuja commented on PR #5119:
URL: https://github.com/apache/solr/pull/5119#issuecomment-6914573282

   > I hate mocks, but yes we have tests that mock and I confess it's a good 
strategy sometimes. So that's my bias.
   > 
   > Seeing we're even mocking a SolrParams of all things (which has a number 
of "real" / simple implementations) has me wondering... like are we over-doing 
the mocking here?
   
   Good point — I'd patched the NPE with an iterator stub, but a real 
ModifiableSolrParams is clearly better. It's now swapped in, the param stubs 
became plain set() calls, and the iterator patch is gone. Done in 
[04ef862](https://github.com/apache/solr/pull/5119/commits/04ef862a91c07f06eea628e64f0f9b84e38dcb39).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to