janhoy opened a new pull request, #5355:
URL: https://github.com/apache/solr/pull/5355

   🤖 *AI-assisted, reviewed by Jan*
   
   Five independent build/CI changes that take the bulk of the noise out of our 
test logs. Measured on the parallel-workflow runs of #5354 (7 workflows, 49 
forked test JVMs): of 3742 lines in the Gradle-running steps, 1746 were neither 
task progress nor test results, and 882 of those came from five message 
families. For `:solr:core` the non-signal share drops from 57% to roughly 7%.
   
   - **Grant URLPermission by wildcard host.** `java.net.HostPortrange` 
normalises a numeric IPv4 authority with a `Formatter` bound to `Locale.US`, 
whose `%d` conversion needs the CLDR locale provider, which cannot load while 
the policy file is still being parsed. The parser swallows the error, warns, 
and silently drops the entry, so the five `127.0.0.1` grants were never in 
effect; the `[::1]` ones survive only because the IPv6 branch uses `%02x`. That 
is [JDK-8305346](https://bugs.openjdk.org/browse/JDK-8305346), won't-fix since 
the security manager goes away in JDK 24. 490 lines across the #5354 runs, ten 
per forked JVM. No value of `java.locale.providers` avoids it; a wildcard host 
parses cleanly and widens nothing, since the `SocketPermission` grants still 
confine every connect to loopback.
   - **Register JDK events in the test policy.** `OtelRuntimeJvmMetrics` opens 
a JFR recording stream, and without `registerEvent` / 
`accessClassInPackage.jdk.{jfr.,}internal.event` the JVM logs `Could not 
initialize JDK events. access denied` and silently runs without the JFR-sourced 
`jvm.system.cpu.utilization` gauge it prefers over JMX. The same three grants 
are already in `solr/server/etc/security.policy`.
   - **Deprecation warnings on per module.** javac's `uses or overrides a 
deprecated API` note is mandatory and unsuppressable (`-nowarn`, `-Xlint:none`, 
`-Xmaxwarns 0` all keep it). The only cure is to turn the warnings on and have 
none left, so `javac.gradle` now keeps a list of clean projects; `:solr:api` 
and `:solr:solrj` are the first two (4 + 9 + 49 warnings fixed or suppressed 
with a reason). 232 lines on CI; other modules keep the note until cleaned the 
same way, `:solr:core` alone has ~332.
   - **Cache the Gradle distribution.** `setup-gradle`'s 
`gradle-home-cache-includes` defaults to `caches` and `notifications`, so 
`wrapper/dists` was never saved and all 10 jobs re-downloaded the Gradle zip, 
banner and progress bar included.
   - **Move the actions off Node 20.** `actions/cache` v4 and 
`actions/setup-java` v4 in the shared composite action were the last two, 
bumped to the v6 SHAs already used elsewhere in the repo.
   
   Reasoning behind silencing the deprecation logs is that we seldom act on 
those per test run anyway. It is more realiastic to do a targeted effort to fix 
deprecations once in a while.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to