epugh commented on code in PR #5355:
URL: https://github.com/apache/solr/pull/5355#discussion_r4594162283


##########
gradle/testing/randomization/policies/solr-tests.policy:
##########
@@ -189,9 +189,12 @@ grant {
   permission java.net.NetPermission "requestPasswordAuthentication";
 
   // for java.net.http.HttpClient.  See HttpJdkSolrClientTest
-  permission "java.net.URLPermission" "http://127.0.0.1:*/solr/-";, 
"HEAD,GET,PUT,POST:*";
-  permission "java.net.URLPermission" "https://127.0.0.1:*/solr/-";, 
"HEAD,GET,PUT,POST:*";
-  permission "java.net.URLPermission" "socket://127.0.0.1:*", "CONNECT:*";
+  // JDK-8305346: a URLPermission with a numeric IPv4 host cannot be parsed 
while the policy is
+  // bootstrapping, so such a grant is dropped with a warning; the 
SocketPermissions above are what

Review Comment:
   shorten, but yeah.



##########
solr/api/src/java/org/apache/solr/client/api/model/AddPackageVersionRequestBody.java:
##########
@@ -24,13 +24,15 @@
 public class AddPackageVersionRequestBody {
 
   @JsonProperty("version")
-  @Schema(description = "The version string for this package version.", 
required = true)
+  @Schema(
+      description = "The version string for this package version.",
+      requiredMode = Schema.RequiredMode.REQUIRED)

Review Comment:
   yep, saw this recently too!



##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpJdkSolrClientTest.java:
##########
@@ -615,6 +615,7 @@ public void testCookieHandlerSettingHonored() throws 
Exception {
   }
 
   @Test
+  @SuppressWarnings("deprecation") // covers the deprecated ping()

Review Comment:
   yeah, when we deprecate something we need to be better about removing it 
from `main` so it doesn't linger.



##########
gradle/java/javac.gradle:
##########
@@ -17,6 +17,14 @@
 
 // Configure Java project defaults.
 
+// Projects that compile free of deprecation warnings and so can keep 
-Xlint:deprecation on.

Review Comment:
   I;'ve been mulling over creating a JIRA with subtasks per deprecation in 
hopes that folks would move on them...  it's been annoying!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to