sarkaramrit1993 opened a new pull request, #5357: URL: https://github.com/apache/solr/pull/5357
https://issues.apache.org/jira/browse/SOLR-17704 # Description Solr carries its own ZooKeeper read/write lock. Curator already ships a well-used one, so this swaps it in. The same lock serves the Collection API and the ConfigSet API. # Solution `ZkDistributedLock` now wraps Curator's `InterProcessReadWriteLock`. Nodes get created per level when the lock is acquired. The fixed order (collection, shard, replica) still prevents deadlock. Acquire and release must happen on one thread. `DistributedLock.isAcquired` is gone, and the root lock dir is now a container node. The znode format changed, so the 11 upgrade notes ask for a full restart with the Overseer off. Failing on mixed major versions is left for a follow-up JIRA. # Tests Lock tests run without `isAcquired`, plus new ones for lazy levels and interrupted waiters. Curator cleans up after an interrupt asynchronously, so those tests poll. To check a lock is really blocked, the test helper waits until the acquiring thread parks in Curator's `LockInternals.internalLockLoop`. If Curator renames that method, the tests time out instead of passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
