sarkaramrit1993 commented on PR #5357:
URL: https://github.com/apache/solr/pull/5357#issuecomment-6994854751

   Thanks for taking the time to look through this, Houston. Fair point, and I 
agree. Swapping the internals without deleting any of our classes only gets us 
halfway. Since this is Solr 11 and we have time to get changes into Curator, 
I'll take that route.
   
   What's still ours and why:
   - **Mirrored locks**: Curator has no way for another node to adopt a lock 
node it doesn't own, which restore's `INSTALLSHARDDATA` needs. I'll either 
propose that to Curator or rework restore so it doesn't need mirroring.
   - **`DistributedMultiLock`**: I'll see whether `InterProcessMultiLock` can 
replace the collection/shard/replica hierarchy.
   - **`deleteEmptyDirs`**: with container parents this may not be needed at 
all.
   - **The two lock factories and the `ZkDistributedLock` wrapper**: these 
should shrink to path building once the above lands.
   
   I took your upgrade note wording, added the `else` blocks, and the lock 
nodes now store the node name. Removals will follow here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to