janhoy opened a new pull request, #5358: URL: https://github.com/apache/solr/pull/5358
🤖 *AI-assisted, reviewed by Jan* - `bin/solr start` now waits with `SolrCLI status --max-wait-secs`, the real readiness check, instead of polling for a TCP listener that Jetty 12 opens before the webapp loads. Spinner, the `Started Solr server on port P (pid=N). Happy searching!` line and the `tail -30 solr.log` on timeout are unchanged. - A start that never completes now exits non-zero: the background wait's status is collected with `wait`, where the old timeout branch `exit`ed only the subshell. `solr restart` and `solr start -e <example>` go through the same wait and inherit both fixes; `solr.cmd` already checked its exit code and needs no change. - That was the last use of `lsof`, so it goes, along with its "no lsof" fallback that slept 10 seconds and declared success. With it go the references it left behind: the installer no longer recommends installing lsof "for more stable start/stop", the ref guide no longer tells Red Hat users to `yum install lsof` first, and the cygwin refusal no longer lists it as a reason. The Docker image stops shipping it too, since nothing in Solr calls it and it is not tooling we support; an image that needs it can add it in a downstream layer. - Validated against a built distribution, 5 runs per case. On a busy CPU the stock script returned success while the embedded ZooKeeper port was not yet listening in 5 of 5 runs; with the fix the node was ready in 5 of 5. Starting on an already-occupied port used to exit 0 in 1.1 s announcing a pid, and now exits 1. Idle, the node was still 0.34–0.60 s short of answering HTTP when the old wait returned, against nothing measurable after. The cost is about a second of start time when idle, which is the wait being honest. `solr restart` and `solr start -e techproducts --no-prompt` still work end to end; `tidy`, shellcheck, `check -x test` and the `test_start_solr.bats` and `test_zk.bats` suites are green on both the picocli and commons-cli paths. https://issues.apache.org/jira/browse/SOLR-18665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
