epugh commented on code in PR #5358:
URL: https://github.com/apache/solr/pull/5358#discussion_r4599008060


##########
solr/bin/solr:
##########
@@ -513,6 +513,21 @@ function run_tool() {
   return $?
 } # end run_tool function
 
+# Wait for the node on $SOLR_PORT_LISTEN to answer, as bin/solr.cmd does. 
Jetty binds its
+# connectors before the Solr webapp starts, so a listening port is no proof of 
readiness.
+function wait_for_solr_ready() {
+  local status_output
+  if status_output=$(run_tool status -p "$SOLR_PORT_LISTEN" --max-wait-secs 
"$SOLR_START_WAIT" 2>&1); then

Review Comment:
   just out of curisotiy, would using the `assert` tool have been useful here?  
 Also, does `assert` use _timeout_ and this tool uses _max-wait-secs_?   Should 
those two parameters align?



##########
changelog/unreleased/SOLR-18665-start-readiness.yml:
##########
@@ -0,0 +1,13 @@
+# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc
+
+title: >
+  `bin/solr start` now waits for the node to be ready, instead of for its port 
to be listening, so a

Review Comment:
   I don't know if being more specific about what "ready" means is worth 
mentioning?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to