Amrit Sarkar created SOLR-18668:
-----------------------------------
Summary: Refuse Collection and ConfigSet API commands without the
Overseer while an older major version node is live
Key: SOLR-18668
URL: https://issues.apache.org/jira/browse/SOLR-18668
Project: Solr
Issue Type: Improvement
Components: SolrCloud
Reporter: Amrit Sarkar
With the Overseer disabled, Collection and ConfigSet API commands take their
locks directly in ZooKeeper. SOLR-17704 moves those locks to Curator recipes,
which changes the lock node format. A 10.x node and an 11 node don't see each
other's locks, so during a rolling upgrade two conflicting commands on the same
collection or configset can run at the same time, and nothing reports an error.
The 11 upgrade notes ask for a full restart or paused API commands, but nothing
enforces that.
Live nodes have advertised their Solr version since 10.0 (SOLR-17620), and
{{ZkController.checkClusterVersionCompatibility}} already uses
{{ZkStateReader.fetchLowestSolrVersion()}} to refuse startup on a major
downgrade (SOLR-17879).
Proposal:
* Before {{DistributedCollectionConfigSetCommandRunner}} takes an API lock,
compare the lowest live node major version with ours.
* If a lower major is live, fail the command with {{INVALID_STATE}} and a
message saying API commands are refused until every node is on the same major
version.
* Only the newer side needs the check. 10.x nodes still lock correctly with
each other, and every cross-version conflict involves an 11 node.
* The check applies during a downgrade too, since the risk is the same, so
{{solr.cloud.downgrade.enabled}} doesn't skip it.
* {{fetchLowestSolrVersion()}} reads each live node once per command. API
commands are rare next to that cost, so no caching.
Once this lands, the upgrade note can say commands are refused during a
mixed-version window instead of warning about silent conflicts.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]