Amrit Sarkar created SOLR-18669:
-----------------------------------

             Summary: ConfigSet API CREATE can deadlock when two creates use 
each other as base without the Overseer
                 Key: SOLR-18669
                 URL: https://issues.apache.org/jira/browse/SOLR-18669
             Project: Solr
          Issue Type: Bug
          Components: SolrCloud
            Reporter: Amrit Sarkar


With the Overseer disabled, {{ConfigSetApiLockFactory.createConfigSetApiLock}} 
builds a multi-lock from a write lock on the new config set and then a read 
lock on the base config set. {{DistributedMultiLock.waitUntilAcquired}} takes 
them in that order.

A CREATE of X from base Y running at the same time as a CREATE of Y from base X 
can each get its write lock and then wait on the other's read lock. Neither 
ever returns. The locks are taken before the existence checks, so both requests 
hang even though at most one of them could succeed.

The old ZooKeeper lock had the same order, and SOLR-17704 keeps it, so this 
predates the Curator change. It needs two conflicting creates at the same 
moment, hence the low priority.

Fix: acquire the two locks in a fixed order, for example sorted by config set 
name.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to