github-actions[bot] commented on PR #5365:
URL: https://github.com/apache/solr/pull/5365#issuecomment-7003219145

   **Automated PR readiness judgements** (LLM-generated; may be wrong; not 
updated on later pushes).
   
   - ✅ [Jira issue in 
title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md): already 
present
   - ✅ 
[Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference):
 type: changed <!-- The PR changes the JSON serialization of several 
search&#45;side response sections &#40;e&#46;​g&#46;​&#44; Luke&#39;s 
histogram&#47;​topTerms&#44; MLT interestingTerms&#44; debug section&#41; from 
flat arrays to objects&#44; which is a non&#45;opt&#45;in change to the 
behavior of existing requests&#46;​ -->
   - ⚠️ [Reference Guide 
update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) **— 
missing**: The change alters the response format of documented endpoints like 
Luke&#44; MoreLikeThis&#44; and SearchHandler&#44; which should be reflected in 
the Reference Guide&#39;s documentation of these handlers and the json&#46;​nl 
parameter behavior&#46;​
   - ✅ [Upgrade 
notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages):
 included <!-- The change alters the JSON response shape for clients using the 
default json&#46;​nl setting &#40;changing from flat arrays to 
objects&#41;&#44; which is a backwards&#45;incompatible change for clients 
parsing these specific sections&#46;​ -->
   - ✅ Tests: not needed <!-- The author explicitly states that no new Java 
tests are added because the shape change is the documented intent of the SIP 
step&#44; and existing tests covering these paths have been run and pass&#59; 
the change is a systematic replacement of NamedList with SimpleOrderedMap for 
unique&#45;keyed sections&#46;​ -->
   
   <!-- Assessed commit c052bb668b36d6f49482cd932b54237999b845b4 -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to