nick-boss-tech commented on code in PR #5365:
URL: https://github.com/apache/solr/pull/5365#discussion_r4636565803


##########
solr/core/src/java/org/apache/solr/handler/admin/LukeRequestHandler.java:
##########
@@ -1276,7 +1276,7 @@ public NamedList<Integer> toNamedList(IndexSchema schema) 
{
         aslist.add(0, pop());
       }
 
-      NamedList<Integer> list = new NamedList<>();
+      NamedList<Integer> list = new SimpleOrderedMap<>();

Review Comment:
   🤖 *AI text below* 🤖
   
   Could we keep `topTerms` as a `NamedList`? The queue holds distinct indexed 
terms, but the response uses `indexedToReadable()` as the key. A legacy 
`TrieIntField` with multiple precision levels can have several indexed terms 
that all [decode to 
`"0"`](https://github.com/isaric/solr-fork/blob/dd557400fe2c31b8d48d31fad942f3d791a9f92d/solr/core/src/java/org/apache/solr/schema/TrieField.java#L466-L484),
 with different document frequencies. The old flat response keeps each entry. 
JSON clients parsing the new object can only see one. The histogram can still 
move to a map independently.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to