janhoy commented on code in PR #5348:
URL: https://github.com/apache/solr/pull/5348#discussion_r4655459422


##########
solr/bin/solr.cmd:
##########
@@ -1200,6 +1201,17 @@ IF "%FG%"=="1" (
       set "SCRIPT_ERROR=Solr did not start or was not reachable. Check the 
logs for errors."
       goto err
   )
+
+  REM START /B leaves us without a PID, so ask netstat who owns the port now 
that Solr is up

Review Comment:
   Good catch. Without a target, `status --max-wait-secs` could return 0 before 
the JVM was even listed (the `--solr-url` arg was lost in SOLR-17685). 
Readiness is now scoped with `status -p <port>`, the same call bin/solr makes 
since SOLR-18665, and the PID file is written before checking the result, as 
bin/solr does.
   



##########
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc:
##########
@@ -91,6 +91,11 @@ A request with no other parameters returns every collection.
 
 The v1 `CLUSTERSTATUS` command is unchanged, and `includeAll` still defaults 
to true.
 
+=== Windows PID Files
+
+On Windows, `bin\solr.cmd` now writes a true `solr-<port>.pid` file instead of 
relying on the `solr-<port>.port` file.
+The `solr-<port>.port` file is deprecated and will be removed in a future 
version.

Review Comment:
   A running node isn't upgraded in place: upgrading means stopping it with the 
old script, replacing the binaries and script, and then starting it with the 
new one. So the new script never has to stop a node that only has a `.port` 
file.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to