[ 
https://issues.apache.org/jira/browse/SPARK-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034735#comment-14034735
 ] 

Patrick Wendell commented on SPARK-2038:
----------------------------------------

Unfortunately after discussion with Reynold, I realized we have to revert this. 
The issue is that we can't change parameter names in public API's because scala 
allows functions to pass arguments by name:

http://docs.scala-lang.org/tutorials/tour/named-parameters.html

So a change like this could break source compatibility for users.

> Don't shadow "conf" variable in saveAsHadoop functions
> ------------------------------------------------------
>
>                 Key: SPARK-2038
>                 URL: https://issues.apache.org/jira/browse/SPARK-2038
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Core
>    Affects Versions: 1.0.0
>            Reporter: Patrick Wendell
>            Assignee: Nan Zhu
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> This could lead to a lot of bugs. We should just change it to hadoopConf. I 
> noticed this when reviewing SPARK-1677.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to