[
https://issues.apache.org/jira/browse/SPARK-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037703#comment-14037703
]
Patrick Wendell commented on SPARK-2038:
----------------------------------------
Hey [~CodingCat] - I realized there is actually an intermediate fix. Don't
change the name of the method argument, but inside of the method immediately do
`val hadoopConf = conf` then add a comment that it's to avoid naming collision.
So I think you could still submit your patch with that change. Does that make
sense?
> Don't shadow "conf" variable in saveAsHadoop functions
> ------------------------------------------------------
>
> Key: SPARK-2038
> URL: https://issues.apache.org/jira/browse/SPARK-2038
> Project: Spark
> Issue Type: Improvement
> Components: Spark Core
> Affects Versions: 1.0.0
> Reporter: Patrick Wendell
> Assignee: Nan Zhu
> Priority: Minor
> Labels: api-breaking
> Fix For: 1.1.0
>
>
> This could lead to a lot of bugs. We should just change it to hadoopConf. I
> noticed this when reviewing SPARK-1677.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
