[ https://issues.apache.org/jira/browse/SPARK-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211935#comment-15211935 ]
Jacek Laskowski commented on SPARK-13998: ----------------------------------------- [~mlnick] It's a simple refactoring, i.e. changing {{extends Transformer with HasInputCol with HasOutputCol}} to {{extends UnaryTransformer[...]}} Is your moving the issue as a subtask a nod to the change? (I'm concerned after having read the other comment from [~yanboliang] and the follow-up from [~josephkb]) > HashingTF should extend UnaryTransformer > ---------------------------------------- > > Key: SPARK-13998 > URL: https://issues.apache.org/jira/browse/SPARK-13998 > Project: Spark > Issue Type: Sub-task > Components: ML > Affects Versions: 2.0.0 > Reporter: Jacek Laskowski > Priority: Minor > > Currently > [HashingTF|https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/feature/HashingTF.scala#L37] > extends {{Transformer with HasInputCol with HasOutputCol}}, but there is a > helper > [UnaryTransformer|https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/Transformer.scala#L79-L80] > abstract class for exactly the reason. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org