[ 
https://issues.apache.org/jira/browse/SPARK-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215743#comment-15215743
 ] 

Nick Pentreath commented on SPARK-13998:
----------------------------------------

It's more house-keeping, to group this under the related improvements to 
feature hashing for consistency. It seems it requires {{Attribute}} support in 
{{UnaryTransformer}} first, which is perhaps low priority. So for now we can 
leave this.

> HashingTF should extend UnaryTransformer
> ----------------------------------------
>
>                 Key: SPARK-13998
>                 URL: https://issues.apache.org/jira/browse/SPARK-13998
>             Project: Spark
>          Issue Type: Sub-task
>          Components: ML
>    Affects Versions: 2.0.0
>            Reporter: Jacek Laskowski
>            Priority: Minor
>
> Currently 
> [HashingTF|https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/feature/HashingTF.scala#L37]
>  extends {{Transformer with HasInputCol with HasOutputCol}}, but there is a 
> helper 
> [UnaryTransformer|https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/Transformer.scala#L79-L80]
>  abstract class for exactly the reason.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to