[
https://issues.apache.org/jira/browse/SPARK-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166415#comment-14166415
]
Sean Owen commented on SPARK-3895:
----------------------------------
To be clear, the second is correct because of line length and brace placement.
However the PR you mention shows the opposite, changing the second into the
first.
The style guide already covers line length and braces. If the net change is
moving braces, I am not sure that's worth doing for its own sake, given it is
completely non-functional. (Although it can be fixed up when nearby code is
edited.) So is there any action that falls out from this JIRA?
> Scala style: Indentation of method
> ----------------------------------
>
> Key: SPARK-3895
> URL: https://issues.apache.org/jira/browse/SPARK-3895
> Project: Spark
> Issue Type: Sub-task
> Components: Project Infra
> Reporter: sjk
>
> such as https://github.com/apache/spark/pull/2734
> {code:title=core/src/main/scala/org/apache/spark/Aggregator.scala|borderStyle=solid}
> // for example
> def combineCombinersByKey(iter: Iterator[_ <: Product2[K, C]], context:
> TaskContext)
> : Iterator[(K, C)] =
> {
> ...
> def combineValuesByKey(iter: Iterator[_ <: Product2[K, V]],
> context: TaskContext): Iterator[(K, C)] = {
> {code}
> there are not conform to the
> rule.https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
> there are so much code like this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
