[
https://issues.apache.org/jira/browse/SPARK-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14170609#comment-14170609
]
Sean Owen commented on SPARK-3895:
----------------------------------
The rule is already in style guide. There seems to be agreement not to change
this all at once. The original PR seemed to contradict the style guide. What
change are you proposing in order to reopen this?
> Scala style: Indentation of method
> ----------------------------------
>
> Key: SPARK-3895
> URL: https://issues.apache.org/jira/browse/SPARK-3895
> Project: Spark
> Issue Type: Sub-task
> Components: Project Infra
> Reporter: sjk
>
> {code:title=core/src/main/scala/org/apache/spark/Aggregator.scala|borderStyle=solid}
> // for example
> def combineCombinersByKey(iter: Iterator[_ <: Product2[K, C]], context:
> TaskContext)
> : Iterator[(K, C)] =
> {
> ...
> def combineValuesByKey(iter: Iterator[_ <: Product2[K, V]],
> context: TaskContext): Iterator[(K, C)] = {
> {code}
> there are not conform to the
> rule.https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
> there are so much code like this
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
