[
https://issues.apache.org/jira/browse/SPARK-22308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211546#comment-16211546
]
Nathan Kronenfeld commented on SPARK-22308:
-------------------------------------------
> Sure, but aren't you saying that the ship has sailed and someone already
> pulled this into a reusable library?
I think not just one, but many people have pulled it out.
And it's only semi-reusable. If something were to change in spark to make that
pattern undesirable, because everyone has their own copy, it would take forever
to propagate (if it even did).
> I'm unclear if you're saying it already has what you want....
Basically, it does have what I want already, if I were using FunSuite-based.
I'm proposing a pretty simple tweak here to allow it to support the other 3
major ScalaTest patterns
> But documenting it as a supported API is a step too far I think.
If you would like the documentation changes taken out of the PR, I can do that.
That is perhaps a larger issue than this PR needs to be. But if we do that, I
would suggest making another issue for it (which I would be happy to do).
Spark should have a documented testing API, whether this one or another, better
one. External testing libraries will always be a version or two behind, and
testing is too fundamental.
> Support unit tests of spark code using ScalaTest using suites other than
> FunSuite
> ---------------------------------------------------------------------------------
>
> Key: SPARK-22308
> URL: https://issues.apache.org/jira/browse/SPARK-22308
> Project: Spark
> Issue Type: Improvement
> Components: Documentation, Spark Core, SQL, Tests
> Affects Versions: 2.2.0
> Reporter: Nathan Kronenfeld
> Priority: Minor
> Labels: scalatest, test-suite, test_issue
>
> External codebases that have spark code can test it using SharedSparkContext,
> no matter how they write their scalatests - basing on FunSuite, FunSpec,
> FlatSpec, or WordSpec.
> SharedSQLContext only supports FunSuite.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
