[
https://issues.apache.org/jira/browse/SPARK-22308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211561#comment-16211561
]
Sean Owen commented on SPARK-22308:
-----------------------------------
Yeah I wouldn't document it. I disagree that it should be an API in the
user-facing sense. A consistent and scaladoc'ed approach internally? yes.
The refactoring looks promising if it's really just collecting common code into
base classes. I don't know the code well enough to evaluate it well, but if
it's not changing functionality, just improving organization, that's good. If
it happens to make it easier for someone to reuse, also all the better.
> Support unit tests of spark code using ScalaTest using suites other than
> FunSuite
> ---------------------------------------------------------------------------------
>
> Key: SPARK-22308
> URL: https://issues.apache.org/jira/browse/SPARK-22308
> Project: Spark
> Issue Type: Improvement
> Components: Documentation, Spark Core, SQL, Tests
> Affects Versions: 2.2.0
> Reporter: Nathan Kronenfeld
> Priority: Minor
> Labels: scalatest, test-suite, test_issue
>
> External codebases that have spark code can test it using SharedSparkContext,
> no matter how they write their scalatests - basing on FunSuite, FunSpec,
> FlatSpec, or WordSpec.
> SharedSQLContext only supports FunSuite.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
