Joel Croteau created SPARK-22415:
------------------------------------
Summary: lint-r fails if lint-r.R installs any new packages
Key: SPARK-22415
URL: https://issues.apache.org/jira/browse/SPARK-22415
Project: Spark
Issue Type: Bug
Components: Tests
Affects Versions: 2.3.0
Environment: OSX 10.12.6 R 3.4.2
Reporter: Joel Croteau
Priority: Minor
The dev/lint-r script checks for lint failures by seeing if anything is output
to stdout by lint-r.R. Since package installations will often produce output to
stdout, this will cause it to report a failure even if lint-r.R succeeded. This
would also mean that if there were a failure further up in lint-r.R that output
a message to stderr, it would not detect this and think lint-r.R had succeeded.
It would be preferable for lint-r.R to output lints to stderr and for lint-r to
check that and/or for lint-r.R to return a failure code if there are any lints,
which lint-r could check for. I will write a patch to do this.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
