[
https://issues.apache.org/jira/browse/STORM-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354656#comment-16354656
]
Erik Weathers commented on STORM-2937:
--------------------------------------
Kind of.
# I still want us to just release 1.0.6 without this, since I don't think it
makes sense to block 1.0.6 on this.
# I also have a bunch of other stuff that I'm working on, including fighting
the newer storm-kafka-client (deserializers configure method not being called,
also took me a long long time to figure out how to even set the deserializer in
1.1.x code, and I still think it's messed up somehow compared to 1.0.x
storm-kafka-client where it just worked fine).
# I also think [~kabhwan] didn't quite understand my comment about the commit
squashing – in my view it's cleaner to record what changes had to be made:
{code}
cp -rp storm-1.x-branch/external/storm-kafka-client
storm-1.0.x-branch/external/storm-kafka-client
git commit -m "non-compiling copy of storm-kafka-client from 1.x-branch at
commit SHA XXXX"
# do whatever changes are necessary to make it compile
git commit -m "changes needed to make it compile"
{code}
But I might have misunderstood how [~kabhwan] backported it?
> Overwrite storm-kafka-client 1.x-branch into 1.0.x-branch
> ---------------------------------------------------------
>
> Key: STORM-2937
> URL: https://issues.apache.org/jira/browse/STORM-2937
> Project: Apache Storm
> Issue Type: Task
> Components: storm-kafka-client
> Affects Versions: 1.0.6
> Reporter: Jungtaek Lim
> Assignee: Erik Weathers
> Priority: Blocker
>
> This is to track the effort of syncing up divergence between
> storm-kafka-client 1.x-branch and 1.0.x-branch so that critical fixes can be
> go in 1.0.x-branch as well.
> Note that it can modify storm-core as well (unlikely in a
> backwards-incompatible way but not 100% sure), so we should make a decision
> whether we allow the change in bugfix version line.
> Linking discussion thread:
> [https://lists.apache.org/thread.html/0451fed132bb982b618d9e0780282a87554f1bc5747827599f276944@%3Cdev.storm.apache.org%3E]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
