reiabreu commented on code in PR #8790:
URL: https://github.com/apache/storm/pull/8790#discussion_r3409820874


##########
storm-client/test/jvm/org/apache/storm/tuple/DetachedTupleTest.java:
##########


Review Comment:
   can we some extra minor tests?
   
   - DetachedTuple  can serialize and deserialize successfully when the tuple 
contains  null
   - include getShort ,  getByte ,  getBoolean in the tests
   - comparing a  DetachedTuple  to  null  or a non- DetachedTuple  instance



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to