rzo1 commented on PR #8790: URL: https://github.com/apache/storm/pull/8790#issuecomment-4702502100
Thanks @dpol1, this looks good. Two small things before merge: - This changes behavior for anyone consuming the late stream in local mode today: the value type goes from `Tuple` to `DetachedTuple` and `getContext()` now throws. It's documented, but please also note it in the changelog/release notes. - The Kryo round-trip tests all serialize a fresh `DetachedTuple` where `fields` is still null, so the transient-skip path isn't actually exercised. A test that calls `getFields()` before the round-trip would lock that in. Otherwise looks correct to me. Happy to approve once those are in, plus @reiabreu's test requests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
