rzo1 commented on PR #8905:
URL: https://github.com/apache/storm/pull/8905#issuecomment-5015270345
Thanks @reiabreu! To save you some work and keep this moving quickly, here's
what I plan to do on this branch:
1. Keep your BasicContainer fix as the core of this PR (once you've dropped
the build-system changes, or I can do that while I'm at it).
2. Push a regression test on top: the existing launch tests mock
frameworkClasspath() away (FRAMEWORK_CP), which is exactly why this regression
went unnoticed — the new test exercises the real implementation and asserts
lib-common/* and lib-worker/* are on the worker classpath.
3. Push a small build change restoring lib-worker/ as an empty drop-in
directory (README only) in both distributions. Operators use it to inject
worker-only jars, and both storm.py and BasicContainer keep it on the worker
classpath — this preserves that extension point and part of the familiar 2.x
layout without re-introducing the 3-way dedup machinery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
