reiabreu commented on PR #8905: URL: https://github.com/apache/storm/pull/8905#issuecomment-5015276646
1 - feel free to drop them Thank you On Sun, 19 Jul 2026 at 10:52, Richard Zowalla ***@***.***> wrote: > *rzo1* left a comment (apache/storm#8905) > <https://github.com/apache/storm/pull/8905#issuecomment-5015270345> > > Thanks @reiabreu <https://github.com/reiabreu>! To save you some work and > keep this moving quickly, here's what I plan to do on this branch: > > 1. > > Keep your BasicContainer fix as the core of this PR (once you've > dropped the build-system changes, or I can do that while I'm at it). > 2. > > Push a regression test on top: the existing launch tests mock > frameworkClasspath() away (FRAMEWORK_CP), which is exactly why this > regression went unnoticed — the new test exercises the real implementation > and asserts lib-common/* and lib-worker/* are on the worker classpath. > 3. > > Push a small build change restoring lib-worker/ as an empty drop-in > directory (README only) in both distributions. Operators use it to inject > worker-only jars, and both storm.py and BasicContainer keep it on the > worker classpath — this preserves that extension point and part of the > familiar 2.x layout without re-introducing the 3-way dedup machinery. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/storm/pull/8905?email_source=notifications&email_token=AAG5GITDQSMYX3PFZWACMXT5FSK6XA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBRGUZDOMBTGQ22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5015270345>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAG5GISCE6XRHPVPVJMZMG35FSK6XAVCNFSNUABEKJSXA33TNF2G64TZHMYTIMJTGU2DOMB3JFZXG5LFHM2DSMRRHEZDQMZZGCQXMAQ> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
