reiabreu commented on PR #9006: URL: https://github.com/apache/storm/pull/9006#issuecomment-5393489279
Thank you for the feedback, @rzo1. I'm afraid I haven't touched C in many years, so I relied entirely on Claude for these fixes. - **1 (O_NONBLOCK):** Added `O_NONBLOCK` to the open flags in `setup_permissions` — no-op for regular files/dirs, `fchown`/`fchmod` on the fd still work, and the `fstat` dev/ino check now rejects a file swapped for a writerless FIFO instead of blocking the root launcher. - **2 (tests):** Not covered here — `setup_dir_permissions` calls `seteuid(0)` and `setup_permissions` is `static`, so the open/`fstat`-failure and dev/ino-mismatch branches need the function de-static'd or a test wrapper; left for a separate test-harness change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
