reiabreu commented on PR #9006: URL: https://github.com/apache/storm/pull/9006#issuecomment-5393728822
Following up on the test-coverage point: exercising the `setup_permissions` branches needs the function de-static'd, and the full privileged walk needs root (which CI's `make check` doesn't run as). I'll fold what's unit-testable — the dev/ino decision — into the same worker-launcher test-coverage follow-up PR once these PRs are on `master`, alongside the `main.c` enforcement tests noted on #9008 and #9010. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
