ErnestasVaiciukeviciusAdform commented on PR #9175: URL: https://github.com/apache/storm/pull/9175#issuecomment-6267992554
> Hi @ErnestasVaiciukeviciusAdform thanks a lot for reporting and addressing this bug! > > If you have bandwidth, can you execute with your changes this topology in a two supervisors cluster with flag on/off? > > https://github.com/apache/storm/blob/master/examples%2Fstorm-perf%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fstorm%2Fperf%2FJitterAwareGroupingTopology.java Sure. Below what i've got running JitterAwareGroupingTopology on codebase with PR changes (2 runs for each case): ``` 4 workers, 2 supervisors - feedback disabled (-c topology.upstream.feedback.enable=false) 120,4,12,12,38640,644,1,2680,2300,44,11400.035,11400.035 second run 120,4,12,12,33380,556,1,2040,2020,34,13016.901,13016.901 4 workers, 2 supervisors - feedback enabled (-c topology.upstream.feedback.enable=true) 120,4,12,12,49680,828,1,3580,3060,59,8996.098,8996.098 second run 120,4,12,12,46240,770,1,3340,2760,55,9766.036,9766.036 ``` Also for comparison on unmodified 3.1.0: ``` 4 workers - feedback disabled 120,4,12,12,39620,660,1,3000,2300,50,11436.565,11436.565 4 workers - feedback enabled 120,4,12,12,38220,637,1,2660,2300,44,11365.287,11365.287 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
