ErnestasVaiciukeviciusAdform commented on PR #9175: URL: https://github.com/apache/storm/pull/9175#issuecomment-6288638981
> A few requests before merging: > > * Please rebase on `master` > * Document the connection fan-in in `docs/Performance.md` (the only place describing the flag) and/or the `TOPOLOGY_UPSTREAM_FEEDBACK_ENABLE` javadoc: with the flag on, every worker hosting a user bolt now opens a Netty client connection to every worker hosting a task of its upstream components > * A few small things on the tests, inline. Addressed all the point. Documentation extended in both `Performance.md` and javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
