rzo1 commented on PR #9182:
URL: https://github.com/apache/storm/pull/9182#issuecomment-6335733774
Thanks @jnioche! All points are addressed in 38d582db4:
1. `/listLogs` and `getAllLogsForRootDir` now leave out topology, port and
file links (tests for all four `listLogFiles` branches).
2. A file replaced by a link between the check and the open now gets the
endpoint's normal 404 without marking the exception meters (tests for download,
dumps, log page, search and deep search).
3. Added the depth change to the description.
4. The `LogFilePaths` Javadoc now states the port-directory ownership
assumption and the reliance on `fs.protected_hardlinks`.
Nits: the daemon page now uses `LogFilePaths.fileLength`, and the downloader
has a single open path. The `getNameCount() != 1` check in the profile handler
stays: `Path.resolve("")` lets `host::1111` plus `1111/worker.jfr` reach depth
3 and get authorized against `topoA//worker.log`. A test covers it now.
Could you have another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
