rzo1 commented on PR #9182: URL: https://github.com/apache/storm/pull/9182#issuecomment-6363541661
@jnioche Thanks for the 2nd review. I added most of the feedback in 410cf076f: - Deep search and the dump listing now skip symlinked port directories (and a topologyId containing a separator) - Download streams are closed once written - The port is parsed after the last `:`, so IPv6 hosts work - Worker files are opened through a single `LogFilePaths.openWorkerFile` - Symlink tests skip where links can't be created; added tests for the symlinked port dir cases Not changed: - **FIFO:** the open itself blocks on a FIFO, so checking the opened channel can't help, and Java has no non-blocking open. It's also a DoS by a trusted submitter, which the security model rules out. I documented it in `LogFilePaths`. - **Old `buildDownloadFile` signature:** master is 3.1.x, and storm-webapp is daemon code rather than a public API. Keeping the old signature would also keep the link-following open around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
