rzo1 commented on PR #9169: URL: https://github.com/apache/storm/pull/9169#issuecomment-6387518554
Thanks for adding the warnings and the doc updates. Two small things: 1. `docs/metrics_v2.md` now says "deprecated in 2.0.0 and removed in 3.0.0". As far as I can see, `storm.metrics.reporters` was deprecated in 2.3.0 (STORM-3670), and it is removed with this PR, so in the next release. The `blobstore.hdfs.*` keys were deprecated in 2.2.0 (STORM-3494). 2. Could you add an `## Upgrade notes` section to the description? Operators who only set `blobstore.hdfs.principal`/`keytab` would otherwise lose the HDFS Kerberos login with just a WARN. The conflicts come from the checkstyle reformat in #9184 and should be mechanical. Nit: there are a few double blank lines left in `Config`, `Nimbus` and `ConfigUtilsTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
