rzo1 commented on PR #9189: URL: https://github.com/apache/storm/pull/9189#issuecomment-6387519262
Thanks, this is a useful addition. Two remarks: 1. `NEXT_HEADING` matches any `# ` line, so a note is cut off at a `# comment` inside a fenced code block, or at a sub-heading. #9168's current notes would come out empty. Ignoring lines inside fences and stopping only at a heading of the same or higher level would cover both. 2. `TEMPLATE_HINT` drops any line shaped `*(...)*`, which could remove real content. Matching the template's literal text seems safer. Nit: titles go into the HTML unescaped (already the case on the existing line). An `html.escape()` would be cheap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
