dpol1 commented on PR #9154: URL: https://github.com/apache/storm/pull/9154#issuecomment-6410946955
1. Done in 0926fbc2b: each test in `TopologyTracingTest` now starts its own cluster, as in `TupleTracerTest`. 2. I updated the references in the description. The cost numbers keep the commits they were measured on, which tags on my fork now hold, and the description says they predate the later commits. Squash on merge is fine with me. On `spoutEmit`: I'd keep the signature unchanged for this first version. The hook runs synchronously during emission (now stated in its Javadoc, 474897204), so a tracer could use context made current by the spout or its instrumentation. Direct extraction from message data would still need an API extension; I'd defer that until we have a concrete integration. The bundled OTel tracer continues to start new roots, as documented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
