Mohit20057 opened a new pull request, #9266:
URL: https://github.com/apache/storm/pull/9266
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
## What is the purpose of the change
Follow-up to umbrella issue #8994 addressing review audit feedback from
#issuecomment-6712947172:
- Completes explicit `since = "..."` and `forRemoval` classification on the
remaining 12 `@Deprecated` declarations on `master` (achieving zero bare
`@Deprecated` across all production code):
- `Flux.java`: Added `since = "2.0.0"`, `forRemoval = true`, and
explanatory Javadocs for obsolete CLI option constants (`OPTION_LOCAL`,
`OPTION_REMOTE`, `OPTION_SLEEP`, `OPTION_ZOOKEEPER`).
- `LinearDRPCTopologyBuilder.java`: Added `since = "1.0.0"` to the two
`addBolt(IRichBolt...)` overloads.
- `TimeCacheMap.java`: Added `since = "0.7.0"` to `TimeCacheMap`
(`forRemoval = false`).
- `NodeSorter.java` & `NodeSorterHostProximity.java`: Added `since =
"2.3.0"`, `forRemoval = false` to private sorting helpers
(`sortObjectResourcesGeneric` and `sortObjectResourcesDefault`).
- `ServerUtils.java`: Added `since = "2.0.0"`, `forRemoval = true` to
`zipFileSize(File)`.
- Updates Javadoc `@deprecated` tags to document explicit replacements:
- `PlainSaslTransportPlugin`: Documented replacement with
`DigestSaslTransportPlugin` or `KerberosSaslTransportPlugin`.
- `SaslPlainServer`: Documented standard SASL mechanism alternatives
(DIGEST-MD5 / GSSAPI).
- `IMetricsContext.registerMetric` (3 overloads): Documented metrics v2
replacement methods (`registerGauge`, `registerCounter`, `registerMeter`,
`registerHistogram`, `registerTimer`).
- `ServerUtils.zipFileSize`: Documented replacement with `File#length()`
or standard Java NIO/zip utilities.
## How was this tested
- Validated repository-wide audit script confirming 0 production
`@Deprecated` annotations missing `since`
- Checkstyle validated with 0 violations across `storm-client`,
`storm-server`, and `flux-core`
- Built and test-compiled `storm-client` with JDK 23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]