Mohit20057 commented on PR #9266: URL: https://github.com/apache/storm/pull/9266#issuecomment-6766561489
Thanks for the thorough review @reiabreu! I have applied all inline suggestions in commit `14793bb`: - Updated the three historical `since` attributes (`TimeCacheMap` -> `0.8.1`, `LinearDRPCTopologyBuilder` overloads -> `0.7.0`, `ServerUtils.zipFileSize` -> `3.2.0`). - Clarified the `zipFileSize` replacement doc regarding uncompressed gzip size vs `File#length()`. - Updated Flux option descriptions (`--local-ttl`, `--local-zookeeper`). - Resolved the Checkstyle `RequireEmptyLineBeforeBlockTagGroup` warnings on `Flux`, `PlainSaslTransportPlugin`, and `SaslPlainServer`. - Added `registerMetricSet` to the `IMetricsContext` replacement lists. Verified with `mvn validate -pl storm-client,storm-server,flux/flux-core` (0 Checkstyle violations). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
