MonsterChenzhuo commented on code in PR #1836:
URL:
https://github.com/apache/incubator-streampark/pull/1836#discussion_r997664527
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/PassportController.java:
##########
@@ -67,39 +67,22 @@ public class PassportController {
public RestResponse signin(
@NotBlank(message = "{required}") String username,
@NotBlank(message = "{required}") String password) throws Exception {
-
if (StringUtils.isEmpty(username)) {
return RestResponse.success().put("code", 0);
}
-
User user = authenticator.authenticate(username, password);
+ return login(username, password, user);
+ }
- if (user == null) {
+ @PostMapping("ldapSignin")
+ public RestResponse ldapSignin(
Review Comment:
The current pr also needs to be matched with a front-end changes, specific
changes to the style and logic have been described in detail at
https://github.com/apache/incubator-streampark/issues/1735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
