MonsterChenzhuo commented on code in PR #1836:
URL:
https://github.com/apache/incubator-streampark/pull/1836#discussion_r997676135
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/PassportController.java:
##########
@@ -67,39 +67,22 @@ public class PassportController {
public RestResponse signin(
@NotBlank(message = "{required}") String username,
@NotBlank(message = "{required}") String password) throws Exception {
-
if (StringUtils.isEmpty(username)) {
return RestResponse.success().put("code", 0);
}
-
User user = authenticator.authenticate(username, password);
+ return login(username, password, user);
+ }
- if (user == null) {
+ @PostMapping("ldapSignin")
+ public RestResponse ldapSignin(
Review Comment:
<img width="977" alt="图片"
src="https://user-images.githubusercontent.com/60029759/196326538-ef1cb77a-d436-471d-8500-36d2107e45f1.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/60029759/196326538-ef1cb77a-d436-471d-8500-36d2107e45f1.png"](https://user-images.githubusercontent.com/60029759/196326538-ef1cb77a-d436-471d-8500-36d2107e45f1.png"){kind=link}