wolfboys commented on code in PR #2262:
URL:
https://github.com/apache/incubator-streampark/pull/2262#discussion_r1084716267
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/MemberController.java:
##########
@@ -53,6 +54,12 @@ public RestResponse memberList(RestRequest restRequest,
Member member) {
return RestResponse.success(userList);
}
+ @PostMapping("candidateUsers")
+ public RestResponse candidateUsers(RestRequest restRequest, Long teamId) {
+ IPage<User> userList = memberService.findCandidateUsers(teamId,
restRequest);
Review Comment:
I suggest return `List<User>` instead of `IPage<User>`, The fact is that
this does not use the paging function
##########
streampark-console/streampark-console-webapp/src/views/system/member/MemberDrawer.vue:
##########
@@ -99,8 +101,17 @@
{
field: 'userName',
label: t('system.member.table.userName'),
- component: 'Input',
- componentProps: { disabled: unref(isUpdate) },
+ component: 'ApiSelect',
+ componentProps: {
+ disabled: unref(isUpdate),
+ api: fetchCandidateUsers,
+ params: { page: 1, pageSize: 9999, teamId: userStore.getTeamId},
Review Comment:
Pagination will add unnecessary trouble, right?
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/service/impl/MemberServiceImpl.java:
##########
@@ -82,6 +82,14 @@ public IPage<Member> findUsers(Member member, RestRequest
request) {
return baseMapper.findUsers(page, member);
}
+ @Override
+ public IPage<User> findCandidateUsers(Long teamId, RestRequest request) {
+ Page<User> page = new Page<>();
+ page.setCurrent(request.getPageNum());
+ page.setSize(request.getPageSize());
+ return baseMapper.findUsersNotInTeam(page, teamId);
Review Comment:
Pagination will add unnecessary trouble, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
