wolfboys commented on code in PR #2262:
URL:
https://github.com/apache/incubator-streampark/pull/2262#discussion_r1084787515
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/controller/MemberController.java:
##########
@@ -53,6 +54,12 @@ public RestResponse memberList(RestRequest restRequest,
Member member) {
return RestResponse.success(userList);
}
+ @PostMapping("candidateUsers")
+ public RestResponse candidateUsers(RestRequest restRequest, Long teamId) {
+ IPage<User> userList = memberService.findCandidateUsers(teamId,
restRequest);
Review Comment:
> @wolfboys thanks for your review & suggestions. The truth what you
described is right. Before reaching a consensus, I want to express the original
intention of this design: The `interface implemented with Pagination` is a
superset of `interface implemented without Pagination` , In other words, if
there are other calls that need paging, the interface can still be reused. It
will lead to some redundancy in the current front-end calling.
>
> Looking forward to the final conclusion from you.
Happy Chinese new year, thanks for your feedback, My point : This method
does not seem to be reusable. That is, it seems to be customized for specific
requests, not a generic method (find user not in team),with explicit query
conditions, what you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
