[GitHub] [incubator-streampark] RocMarshal commented on a diff in pull request #2582: [Improve] support delete flink home

[via GitHub]

RocMarshal commented on code in PR #2582:
URL: 
https://github.com/apache/incubator-streampark/pull/2582#discussion_r1160686908


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkEnvServiceImpl.java:
##########
@@ -39,6 +42,8 @@
 public class FlinkEnvServiceImpl extends ServiceImpl<FlinkEnvMapper, FlinkEnv>
     implements FlinkEnvService {
 
+  @Autowired private FlinkClusterService flinkClusterService;
+  @Autowired private ApplicationService applicationService;

Review Comment:
   ```suggestion
     @Autowired private ApplicationService applicationService;
     
   ```



##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationServiceImpl.java:
##########
@@ -533,6 +533,13 @@ public boolean existsJobByClusterId(Long clusterId) {
     return baseMapper.existsJobByClusterId(clusterId);
   }
 
+  @Override
+  public boolean existsJobByFlinkEnvId(Long flinkEnvId) {
+    LambdaQueryWrapper<Application> lambdaQueryWrapper =
+        new LambdaQueryWrapper<Application>().eq(Application::getVersionId, 
flinkEnvId);
+    return this.count(lambdaQueryWrapper) > 0;

Review Comment:
   May here use `getBaseMapper() .exists(....` ?



##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/FlinkClusterServiceImpl.java:
##########
@@ -323,6 +323,13 @@ public Boolean existsByClusterName(String clusterName, 
Long id) {
     return this.baseMapper.existsByClusterName(clusterName, id);
   }
 
+  @Override
+  public Boolean existsByFlinkEnvId(Long flinkEnvId) {
+    LambdaQueryWrapper<FlinkCluster> lambdaQueryWrapper =
+        new LambdaQueryWrapper<FlinkCluster>().eq(FlinkCluster::getVersionId, 
flinkEnvId);
+    return this.count(lambdaQueryWrapper) > 0;

Review Comment:
   same as mentioned above.



##########
streampark-console/streampark-console-webapp/src/locales/lang/zh-CN/setting/flinkHome.ts:
##########
@@ -18,6 +18,8 @@ export default {
   title: 'Flink Home',
   conf: 'Flink 配置',
   sync: '配置同步',
+  edit: '编辑 Flink Home',
+  delete: '确定要删除此 Flink home ?',

Review Comment:
   I checked the  header of the edit tab window is :
   <img width="1493" alt="image" 
src="https://user-images.githubusercontent.com/64569824/230619899-3c4d35de-365b-4be3-b082-9b9de0faa873.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@streampark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org