zhoulii commented on PR #2582: URL: https://github.com/apache/incubator-streampark/pull/2582#issuecomment-1500404764
> @zhoulii Thanks for your contribution & quick-drive I left a few of comments. PTAL in your free time. > > May the items from my limit read as follows get your @wolfboys @zhoulii confirmation ? > > 1. If there are running jobs or sessions using the target flinkhome, it would be better not to support changing Flinkhome to avoid abnormal risks when some savepoints are triggered. > 2. The `delete`,`update`,`create` api have no `ApiAccess` or `XXXPermission` annotations . Is here any risk ? > > I'd appreciated with your confirmation. thanks~ @RocMarshal Thanks for the review. I agree with you, maybe we can hanle these in another pr, and let this one focus on delete operation. what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
