RocMarshal commented on code in PR #2809:
URL:
https://github.com/apache/incubator-streampark/pull/2809#discussion_r1242310171
##########
streampark-console/streampark-console-service/src/main/assembly/script/upgrade/pgsql/2.2.0.sql:
##########
@@ -57,7 +57,10 @@ alter table "public"."t_flink_sql"
add column "team_resource" varchar(64) default null;
alter table "public"."t_flink_cluster"
- add column "job_manager_url" varchar(150) collate "pg_catalog"."default";
+ add column "job_manager_url" varchar(150) collate "pg_catalog"."default",
+ add column "start_time" timestamp(6) collate "pg_catalog"."default",
+ add column "end_time" timestamp(6) collate "pg_catalog"."default",
+ add column "alert_id" int8 collate "pg_catalog"."default";
Review Comment:
same as the mentioned above.
##########
streampark-console/streampark-console-service/src/main/assembly/script/upgrade/mysql/2.2.0.sql:
##########
@@ -44,7 +44,10 @@ alter table `t_flink_sql`
add column `team_resource` varchar(64) default null;
alter table `t_flink_cluster`
- add column `job_manager_url` varchar(150) default null comment 'url
address of jobmanager' after `address`;
+ add column `job_manager_url` varchar(150) default null comment 'url
address of jobmanager' after `address`,
+ add column `start_time` datetime default null comment 'start time',
+ add column `end_time` datetime default null comment 'end time',
+ add column `alert_id` bigint default null comment 'alert id';
Review Comment:
Do we need to split it into two statements based on PR granularity here?
CC @wolfboys
##########
streampark-console/streampark-console-service/src/main/resources/mapper/core/ApplicationMapper.xml:
##########
@@ -133,6 +133,14 @@
limit 1
</select>
+ <select id="getJobByClusterId" resultType="java.lang.Integer"
parameterType="java.lang.Long">
+ SELECT
+ count(1)
+ FROM t_flink_app
+ WHERE flink_cluster_id = #{clusterId}
+ limit 1
+ </select>
+
Review Comment:
- Do we need to filter the status of the job here ?
I sorted out briefly the background and logic.
Assuming there is a job with a status of cancelled but current cluster
information, will this job be counted if the cluster is abnormal?
- We'd better to get a better select-id name here.
Please correct me if I'm wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
