xujiangfeng001 commented on code in PR #2809:
URL:
https://github.com/apache/incubator-streampark/pull/2809#discussion_r1243998046
##########
streampark-console/streampark-console-service/src/main/assembly/script/upgrade/mysql/2.2.0.sql:
##########
@@ -44,7 +44,10 @@ alter table `t_flink_sql`
add column `team_resource` varchar(64) default null;
alter table `t_flink_cluster`
- add column `job_manager_url` varchar(150) default null comment 'url
address of jobmanager' after `address`;
+ add column `job_manager_url` varchar(150) default null comment 'url
address of jobmanager' after `address`,
+ add column `start_time` datetime default null comment 'start time',
+ add column `end_time` datetime default null comment 'end time',
+ add column `alert_id` bigint default null comment 'alert id';
Review Comment:
I believe that these three statements are all related to the granularity of
the `flink cluster` alarm, so I do not think it is necessary to divide them
into multiple statements. If I am wrong, please correct me. CC @wolfboys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
