wolfboys commented on code in PR #2913:
URL:
https://github.com/apache/incubator-streampark/pull/2913#discussion_r1285207240
##########
streampark-flink/streampark-flink-kubernetes/src/main/scala/org/apache/streampark/flink/kubernetes/KubernetesRetriever.scala:
##########
@@ -107,7 +116,7 @@ object KubernetesRetriever extends Logger {
* deployment namespace
*/
def isDeploymentExists(name: String, namespace: String): Boolean = {
- using(KubernetesRetriever.newK8sClient()) {
+ using(KubernetesRetriever.getK8sClient()) {
Review Comment:
The KubernetesRetriever.getK8sClient() method will return a singleton
KubernetesClient. However, the using method closes the KubernetesClient after
used, which can lead to bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
