ChengJie1053 commented on code in PR #2913:
URL:
https://github.com/apache/incubator-streampark/pull/2913#discussion_r1285309999
##########
streampark-flink/streampark-flink-kubernetes/src/main/scala/org/apache/streampark/flink/kubernetes/KubernetesRetriever.scala:
##########
@@ -47,15 +47,24 @@ object KubernetesRetriever extends Logger {
// see org.apache.flink.configuration.RestOptions.RETRY_MAX_ATTEMPTS
val FLINK_REST_RETRY_MAX_ATTEMPTS = 2
+ private var kubernetesClient: KubernetesClient = _
+
/** get new KubernetesClient */
@throws(classOf[KubernetesClientException])
- def newK8sClient(): KubernetesClient = {
- new DefaultKubernetesClient()
+ def getK8sClient(): KubernetesClient = {
Review Comment:
Ok, thanks for reviewing the code
##########
streampark-flink/streampark-flink-kubernetes/src/main/scala/org/apache/streampark/flink/kubernetes/KubernetesRetriever.scala:
##########
@@ -107,7 +116,7 @@ object KubernetesRetriever extends Logger {
* deployment namespace
*/
def isDeploymentExists(name: String, namespace: String): Boolean = {
- using(KubernetesRetriever.newK8sClient()) {
+ using(KubernetesRetriever.getK8sClient()) {
Review Comment:
Ok, thanks for reviewing the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
