caicancai commented on code in PR #3426:
URL:
https://github.com/apache/incubator-streampark/pull/3426#discussion_r1436197917
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/application/impl/ApplicationActionServiceImpl.java:
##########
@@ -390,6 +394,17 @@ public void start(Application appParam, boolean auto)
throws Exception {
ApiAlertException.throwIfTrue(
!application.isCanBeStart(), "[StreamPark] The application cannot be
started repeatedly.");
+ if (FlinkExecutionMode.isRemoteMode(application.getFlinkExecutionMode())
+ ||
FlinkExecutionMode.isYarnSessionMode(application.getFlinkExecutionMode())) {
+
+ checkBeforeStart(application);
+ }
+
+ if
(FlinkExecutionMode.isKubernetesSessionMode(application.getFlinkExecutionMode().getMode()))
{
+
Review Comment:
Why is there a blank line here?
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/application/impl/ApplicationActionServiceImpl.java:
##########
@@ -390,6 +394,17 @@ public void start(Application appParam, boolean auto)
throws Exception {
ApiAlertException.throwIfTrue(
!application.isCanBeStart(), "[StreamPark] The application cannot be
started repeatedly.");
+ if (FlinkExecutionMode.isRemoteMode(application.getFlinkExecutionMode())
+ ||
FlinkExecutionMode.isYarnSessionMode(application.getFlinkExecutionMode())) {
+
Review Comment:
Why is there a blank line here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
